lkml.org 
[lkml]   [2008]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch, -git] isdn: hysdn_procconf.c build fix

    x86.git randconfig testing found the following build error in latest
    -git:

    CC [M] drivers/isdn/hysdn/hysdn_procconf.o
    CC [M] drivers/isdn/hysdn/hysdn_init.o
    drivers/isdn/hysdn/hysdn_procconf.c: In function 'hysdn_procconf_init':
    drivers/isdn/hysdn/hysdn_procconf.c:408: error: too few arguments to function 'proc_create'

    with the following config:

    http://redhat.com/~mingo/misc/config-Wed_Apr_30_15_12_48_CEST_2008.bad

    Ob'grumpy: this file was not even build-tested by any of the parties who
    turned it into upstream commit ac41cfd19b ("isdn: use non-racy method
    for proc entries creation").

    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    drivers/isdn/hysdn/hysdn_procconf.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    Index: linux/drivers/isdn/hysdn/hysdn_procconf.c
    ===================================================================
    --- linux.orig/drivers/isdn/hysdn/hysdn_procconf.c
    +++ linux/drivers/isdn/hysdn/hysdn_procconf.c
    @@ -405,7 +405,8 @@ hysdn_procconf_init(void)
    sprintf(conf_name, "%s%d", PROC_CONF_BASENAME, card->myid);
    if ((card->procconf = (void *) proc_create(conf_name,
    S_IFREG | S_IRUGO | S_IWUSR,
    - hysdn_proc_entry)) != NULL) {
    + hysdn_proc_entry,
    + &conf_fops)) != NULL) {
    hysdn_proclog_init(card); /* init the log file entry */
    }
    card = card->next; /* next entry */

    \
     
     \ /
      Last update: 2008-04-30 20:01    [W:4.663 / U:0.580 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site