Messages in this thread Patch in this message | | | Date | Wed, 30 Apr 2008 14:05:09 +0200 | From | Ingo Molnar <> | Subject | Re: [patch, -git] media/video/sound build fix, TEA5761/TEA5767 |
| |
* Takashi Iwai <tiwai@suse.de> wrote:
> > default SND_FM801 > > + select VIDEO_V4L1_COMPAT > > > > config SND_HDA_INTEL > > tristate "Intel HD Audio" > > This one shouldn't be needed with my patch.
ok, removed it, we'll see.
I also have the one below, of similar pattern. (so it's 8 fixlets, otherwise it's a vanilla kernel in this area)
Ingo
---------------> Subject: video: STKWEBCAM fixes From: Ingo Molnar <mingo@elte.hu> Date: Tue Apr 29 15:11:29 CEST 2008
x86.git randconfig testing found these build bugs in -git:
drivers/media/video/stk-webcam.c: In function 'stk_create_sysfs_files': drivers/media/video/stk-webcam.c:340: error: implicit declaration of function 'video_device_create_file' drivers/media/video/stk-webcam.c: In function 'stk_remove_sysfs_files': [...] drivers/media/video/stk-webcam.c: In function 'v4l_stk_mmap': drivers/media/video/stk-webcam.c:846: error: 'VM_WRITE' undeclared (first use in this function) [...]
config at:
http://redhat.com/~mingo/misc/config-Tue_Apr_29_15_00_47_CEST_2008.bad
the reason was a missing include file, and a dependency on a deprecated (but still in use) VIDEO_V4L1_COMPAT API.
Signed-off-by: Ingo Molnar <mingo@elte.hu> --- drivers/media/video/Kconfig | 1 + drivers/media/video/stk-webcam.c | 1 + 2 files changed, 2 insertions(+)
Index: linux/drivers/media/video/Kconfig =================================================================== --- linux.orig/drivers/media/video/Kconfig +++ linux/drivers/media/video/Kconfig @@ -883,6 +883,7 @@ config USB_ZR364XX config USB_STKWEBCAM tristate "USB Syntek DC1125 Camera support" depends on VIDEO_V4L2 && EXPERIMENTAL + select VIDEO_V4L1_COMPAT ---help--- Say Y here if you want to use this type of camera. Supported devices are typically found in some Asus laptops, Index: linux/drivers/media/video/stk-webcam.c =================================================================== --- linux.orig/drivers/media/video/stk-webcam.c +++ linux/drivers/media/video/stk-webcam.c @@ -28,6 +28,7 @@ #include <linux/errno.h> #include <linux/slab.h> #include <linux/kref.h> +#include <linux/mm.h> #include <linux/usb.h> #include <linux/vmalloc.h>
| |