Messages in this thread | | | Subject | Re: [PATCH] procfs task exe symlink | From | Matt Helsley <> | Date | Wed, 30 Apr 2008 04:02:38 -0700 |
| |
On Sat, 2008-04-26 at 17:24 +0100, Al Viro wrote: > On Sat, Apr 26, 2008 at 09:19:30AM -0700, Andrew Morton wrote: > > > + set_mm_exe_file(bprm->mm, bprm->file); > > + > > /* > > * Release all of the old mmap stuff > > */ > > > > However I'd ask that you conform that this is OK. If set_mm_exe_file() is > > independent of unshare_files() then we're OK. If however there is some > > ordering dependency then we'll need to confirm that the present ordering of the > > unshare_files() and set_mm_exe_file() is correct. > > No, that's fine (unshare_files() had to go up for a lot of reasons, one > of them being that it can fail and de_thread() called just above is > very much irreversible).
They are independent. It just needs to be called before exec_mmap() -- so your fix looks good.
Cheers, -Matt Helsley
| |