Messages in this thread Patch in this message | | | Date | Wed, 30 Apr 2008 13:01:15 +0200 | From | Ingo Molnar <> | Subject | [patch, -git] media/video/sound build fix, TEA5761/TEA5767 |
| |
x86.git randconfig testing found the following new build error in latest -git:
drivers/built-in.o: In function `v4l2_i2c_drv_attach_legacy': tuner-core.c:(.text+0x1a829d): undefined reference to `v4l2_i2c_attach' drivers/built-in.o: In function `tuner_command': tuner-core.c:(.text+0x1a971c): undefined reference to `v4l_printk_ioctl'
the reason appears to be that the TEA5761/TEA5767 tuner code is dependent on (legacy?) V4L infrastructure like v4l2_i2c_attach, by virtue of drivers/media/video/tuner-core.c including media/v4l2-i2c-drv-legacy.h and ./sound/i2c/other/Makefile doing:
snd-tea575x-tuner-objs := tea575x-tuner.o
for now i solved this via adding a VIDEO_V4L2_COMMON dependency to MEDIA_TUNER - which solves the build problem by excluding these drivers - but i suspect there might be a better fix as well that does not restrict the selectability of these drivers.
Signed-off-by: Ingo Molnar <mingo@elte.hu> --- drivers/media/common/tuners/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/media/common/tuners/Kconfig =================================================================== --- linux.orig/drivers/media/common/tuners/Kconfig +++ linux/drivers/media/common/tuners/Kconfig @@ -20,7 +20,7 @@ config MEDIA_ATTACH config MEDIA_TUNER tristate default DVB_CORE || VIDEO_DEV - depends on DVB_CORE || VIDEO_DEV + depends on (DVB_CORE || VIDEO_DEV) && VIDEO_V4L2_COMMON select MEDIA_TUNER_XC2028 if !MEDIA_TUNER_CUSTOMIZE select MEDIA_TUNER_XC5000 if !MEDIA_TUNER_CUSTOMIZE select MEDIA_TUNER_MT20XX if !MEDIA_TUNER_CUSTOMIZE
| |