lkml.org 
[lkml]   [2008]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm] Make the memory controller more desktop responsive
KAMEZAWA Hiroyuki wrote:
> On Thu, 03 Apr 2008 15:02:53 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>> This patch makes the memory controller more responsive on my desktop.
>>
>> Here is what the patch does
>>
>> 1. Reduces the number of retries to 2. We had 5 earlier, since we
>> were controlling swap cache as well. We pushed data from mappings
>> to swap cache and we needed additional passes to clear out the cache.
>
> Hmm, what this change improves ?
> I don't want to see OOM.
>

I had set it to 5 earlier, since the swap cache came back to our memory
controller, where it was accounted. I have not seen OOM with it on my desktop,
but at some point if the memory required is so much that we cannot fulfill it,
we do OOM. I have not seen any OOM so far with these changes.

>> 2. It sets all cached pages as inactive. We were by default marking
>> all pages as active, thus forcing us to go through two passes for
>> reclaiming pages
> Agreed.
>
>> 3. Removes congestion_wait(), since we already have that logic in
>> do_try_to_free_pages()
>>
> Agreed.


--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL


\
 
 \ /
  Last update: 2008-04-03 11:47    [W:0.033 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site