Messages in this thread | | | Subject | Re: [PATCH 4 of 6] hotplug-memory: use common online_page | From | Dave Hansen <> | Date | Thu, 03 Apr 2008 18:22:38 -0700 |
| |
On Thu, 2008-04-03 at 18:11 -0700, Jeremy Fitzhardinge wrote: > Dave Hansen wrote: > > I guess we could just make the copies conditional on CONFIG_HIGHMEM and > > define them both next to each other. It's really a highmem thing more > > than a per-arch thing. > > Sounds good to me. On that subject, how different are the various > arch_add_memory() functions really? There seems to be a lot of common > stuff in there.
Not to different last I looked. But, they're small enough (like online_page()) that we didn't really care. We waited for someone like you to come along and care enough to fix it up. :)
-- Dave
| |