lkml.org 
[lkml]   [2008]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5 of 6] hotplug-memory: add section_ops
From
Date
On Thu, 2008-04-03 at 17:05 -0700, Jeremy Fitzhardinge wrote:
> Add a per-section "section_ops" structure, allowing each section to have
> specific functions for onlining and offlining pages within the section.
> This is used by the Xen balloon driver to make sure that pages are not
> onlined without some physical memory backing them.

This is kinda a lot of code and mucking around for what we actually get
out of it, especially since you just condensed down all the actual
online_page() instances.

I think it might just be nicer to have a global list of these handlers
somewhere. The Xen driver can just say "put me on the list of
callbacks" and we'll call them at online_page(). I really don't think
we need to be passing an ops structure around.

KAME, did you have some other ideas about this?

-- Dave



\
 
 \ /
  Last update: 2008-04-04 02:53    [W:0.108 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site