lkml.org 
[lkml]   [2008]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC 01/22] Generic show_mem() implementation
Date
Hi,

Sam Ravnborg <sam@ravnborg.org> writes:

> On Thu, Apr 03, 2008 at 04:49:42PM +0200, Johannes Weiner wrote:
>> Hi,
>>
>> Sam Ravnborg <sam@ravnborg.org> writes:
>>
>> >> e.g. we currently have this in arch/s390/Kconfig:
>> >>
>> >> config S390
>> >> def_bool y
>> >> select HAVE_OPROFILE
>> >> select HAVE_KPROBES
>> >> select HAVE_KRETPROBES
>> >>
>> >> just add a select HAVE_GENERIC_SHOWMEM or something like that in the arch
>> >> specific patches.
>> > Seconded.
>> > See Documentation/kbuild/kconfig-language.txt for a few more hints
>> > how to do it.
>>
>> After more thinking about it, wouldn't it be better to have
>> HAVE_ARCH_SHOW_MEM in mm/Kconfig and let archs with their own show_mem()
>> select it? Because there are far more archs that use the generic
>> version than those having their own.
>
> Positive logic is almost always simpler to grasp.
> And the usual way to do this is to let arch's select what they
> use.
> We do not want to have a situation where in most cases we select
> a generic version but in some oddball case we select to have
> a local version.

I can not follow you. Of course the arch selects what they use. But
they should not _all_ have to be flagged with an extra select. So what
default-value are you arguing for?

Hannes


\
 
 \ /
  Last update: 2008-04-04 00:37    [W:0.083 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site