lkml.org 
[lkml]   [2008]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm] Add an owner to the mm_struct (v7)
Paul Menage wrote:
> On Thu, Apr 3, 2008 at 11:34 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>> That is indeed quite bad. Do we have to retire the group_leader to init_css_set?
>> Can we not check for delay_group_leader() there?
>>
>
> That might have unintentded consequences, such as leaving a pid in the
> cgroup that can't be moved (since it's PF_EXITING) but won't go away
> until its threads have all exited.
> Maybe that's OK if the other threads are guaranteed to have started
> exiting by this point. We'd need some cleanup for when the group
> leader finally did exit.

Yes, we might be stuck with an unremovable group, but I am not sure how to
address the side-effect at this point. Not having that check could mean that
mm_update_new_owner() will be called very frequently and for thousands of
threads that could clearly become an overhead, if threads start exiting one by
one - lead by the thread group leader.

--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL


\
 
 \ /
  Last update: 2008-04-03 20:51    [W:0.097 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site