lkml.org 
[lkml]   [2008]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm] Add an owner to the mm_struct (v6)
On Thu, Apr 3, 2008 at 12:30 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> + This option enables mm_struct's to have an owner. The advantage
> + of this approach is that it allows for several independent memory
> + based cgorup controllers to co-exist independently without too

cgorup -> cgroup

> + if (need_mm_owner_callback) {
> + int i;
> + for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
> + struct cgroup_subsys *ss = subsys[i];
> + oldcgrp = task_cgroup(old, ss->subsys_id);
> + newcgrp = task_cgroup(new, ss->subsys_id);
> + if (oldcgrp == newcgrp)
> + continue;
> + if (ss->mm_owner_changed)
> + ss->mm_owner_changed(ss, oldcgrp, newcgrp);

Even better, maybe just pass in the relevant cgroup_subsys_state
objects here, rather than the cgroup objects?

>
> css_get(&mem->css);
> - rcu_assign_pointer(mm->mem_cgroup, mem);
> css_put(&old_mem->css);

These get/put calls are now unwanted?

Could you also add comments in mm_need_new_owner(), in particular the
reason for checking for delay_group_leader() ?

Paul


\
 
 \ /
  Last update: 2008-04-03 17:49    [W:0.044 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site