Messages in this thread | | | From | Johannes Weiner <> | Subject | Re: [RFC 01/22] Generic show_mem() implementation | Date | Thu, 03 Apr 2008 15:30:23 +0200 |
| |
Hi,
Sam Ravnborg <sam@ravnborg.org> writes:
>> > + >> > +config HAVE_ARCH_SHOW_MEM >> > + def_bool y >> >> These are all not necessary. Better add some global Kconfig option that >> gets selected by an arch if it wants the generic implementation. >> >> e.g. we currently have this in arch/s390/Kconfig: >> >> config S390 >> def_bool y >> select HAVE_OPROFILE >> select HAVE_KPROBES >> select HAVE_KRETPROBES >> >> just add a select HAVE_GENERIC_SHOWMEM or something like that in the arch >> specific patches. > Seconded. > See Documentation/kbuild/kconfig-language.txt for a few more hints > how to do it.
Yes, I will rework the patches. Thanks.
Hannes
| |