Messages in this thread | | | Date | Thu, 3 Apr 2008 14:48:20 +0200 | From | Sam Ravnborg <> | Subject | Re: [RFC 01/22] Generic show_mem() implementation |
| |
On Thu, Apr 03, 2008 at 09:55:45AM +0200, Heiko Carstens wrote: > > diff --git a/arch/alpha/Kconfig b/arch/alpha/Kconfig > > index 729cdbd..efffa92 100644 > > --- a/arch/alpha/Kconfig > > +++ b/arch/alpha/Kconfig > > @@ -598,6 +598,9 @@ config ALPHA_LARGE_VMALLOC > > > > Say N unless you know you need gobs and gobs of vmalloc space. > > > > +config HAVE_ARCH_SHOW_MEM > > + def_bool y > > + > > config VERBOSE_MCHECK > > bool "Verbose Machine Checks" > > > > diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig > > index 76348f0..acad217 100644 > > --- a/arch/arm/mm/Kconfig > > +++ b/arch/arm/mm/Kconfig > > @@ -673,3 +673,6 @@ config OUTER_CACHE > > config CACHE_L2X0 > > bool > > select OUTER_CACHE > > + > > +config HAVE_ARCH_SHOW_MEM > > + def_bool y > > These are all not necessary. Better add some global Kconfig option that > gets selected by an arch if it wants the generic implementation. > > e.g. we currently have this in arch/s390/Kconfig: > > config S390 > def_bool y > select HAVE_OPROFILE > select HAVE_KPROBES > select HAVE_KRETPROBES > > just add a select HAVE_GENERIC_SHOWMEM or something like that in the arch > specific patches. Seconded. See Documentation/kbuild/kconfig-language.txt for a few more hints how to do it.
Sam
| |