Messages in this thread | | | Date | Thu, 03 Apr 2008 14:31:13 +0200 | From | Jochen Friedrich <> | Subject | Re: [PATCH] [POWERPC] CPM1: implement GPIO LIB API |
| |
Hi Laurent,
> I haven't checked all CPM1-based parts, but for the MPC855 family this doesn't > look right. The MPC855 has two 32-bit ports, port B and port E. Registers for > port B are dir, par, odr and dat, and registers for port E are dir, par, sor, > odr and dat.
You probably mean MPC885. Thanks for catching this, the 32bit registers really are a mess on CPM1 platforms.
> Are you working on a similar patch for the CPM2 ? CPM2 I/O ports are 32 bit > wide and their registers are layed out like for port E on the MPC855. It > should thus be possible to share code between CPM1 and CPM2.
Yes, some common port setup code could probably be moved to cpm.c.
Thanks, Jochen
| |