| Date | Thu, 3 Apr 2008 20:41:24 +0900 | From | Paul Mundt <> | Subject | Re: [RFC 18/22] sh: Use generic show_mem() |
| |
On Wed, Apr 02, 2008 at 10:40:24PM +0200, Johannes Weiner wrote: > - printk(KERN_INFO "Total of %ld pages in page table cache\n", > - quicklist_total_size()); > -} > -
NACK. The quicklists are also absent from the generic implementation. Doing things generically is nice and all, but please do not go around removing all of the different implementations and consolidating on the simplest point of commonality you could come up with. Either combine everything in to a generic show_mem() that doesn't sacrifice functionality, or only convert the platforms that are identical.
|