Messages in this thread Patch in this message | | | Date | Tue, 29 Apr 2008 17:17:32 +0900 | From | KOSAKI Motohiro <> | Subject | [PATCH] on memoryless node, /proc/pagetypeinfo is displayed slightly funny output. take2 |
| |
> > Index: b/mm/vmstat.c > > =================================================================== > > --- a/mm/vmstat.c 2008-04-29 16:48:58.000000000 +0900 > > +++ b/mm/vmstat.c 2008-04-29 16:58:33.000000000 +0900 > > @@ -638,6 +638,10 @@ static int pagetypeinfo_show(struct seq_ > > { > > pg_data_t *pgdat = (pg_data_t *)arg; > > > > + /* check memoryless ndoe*/ > > ndoe -> node ?
Agghhh! you are right ;-)
fixed version is here.
================================================================= on memoryless node, /proc/pagetypeinfo is displayed slightly funny output. this patch fix it.
output example (header is outputed, but no data is outputed) -------------------------------------------------------------- Page block order: 14 Pages per block: 16384
Free pages count per migrate type at order 0 1 2 3 4 5 \ 6 7 8 9 10 11 12 13 14 15 16
Number of blocks type Unmovable Reclaimable Movable Reserve Isolate Page block order: 14 Pages per block: 16384
Free pages count per migrate type at order 0 1 2 3 4 5 \ 6 7 8 9 10 11 12 13 14 15 16
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> CC: Mel Gorman <mel@csn.ul.ie> --- mm/vmstat.c | 4 ++++ 1 file changed, 4 insertions(+)
Index: b/mm/vmstat.c =================================================================== --- a/mm/vmstat.c 2008-04-29 16:48:58.000000000 +0900 +++ b/mm/vmstat.c 2008-04-29 16:58:33.000000000 +0900 @@ -638,6 +638,10 @@ static int pagetypeinfo_show(struct seq_ { pg_data_t *pgdat = (pg_data_t *)arg;
+ /* check memoryless node */ + if (!node_state(pgdat->node_id, N_HIGH_MEMORY)) + return 0; + seq_printf(m, "Page block order: %d\n", pageblock_order); seq_printf(m, "Pages per block: %lu\n", pageblock_nr_pages); seq_putc(m, '\n');
| |