Messages in this thread | | | Date | Tue, 29 Apr 2008 16:12:55 +0800 (CST) | Subject | Re: [PATCH 7/19] UML - Move hppfs_kern.c to hppfs.c | From | WANG Cong <> |
| |
On Mon, 28 Apr 2008, Jeff Dike wrote:
> On Sat, Apr 26, 2008 at 05:17:55PM +0800, WANG Cong wrote: >> > +static struct inode *get_inode(struct super_block *, struct dentry *); >> > + >> > +struct hppfs_data { >> > + struct list_head list; >> > + char contents[PAGE_SIZE - sizeof(struct list_head)]; >> > +}; >> > + >> > +struct hppfs_private { >> > + struct file *proc_file; >> > + int host_fd; >> > + loff_t len; >> > + struct hppfs_data *contents; >> > +}; >> > + >> > +struct hppfs_inode_info { >> > + struct dentry *proc_dentry; >> > + struct inode vfs_inode; >> > +}; >> > + >> > +static inline struct hppfs_inode_info *HPPFS_I(struct inode *inode) >> > +{ >> > + return container_of(inode, struct hppfs_inode_info, vfs_inode); >> > +} >> > + >> > +#define HPPFS_SUPER_MAGIC 0xb00000ee >> >> >> These can be put into a single header, e.g. hppfs.h. > > Why, when this one C file is the only user?
Just looks cleaner for me. ;-)
<snip>
> > Oops, nice spotting. > > See what you think about the patch below...
<snip>
This patch looks OK for me. Thank you!
Cong
| |