Messages in this thread | | | Date | Tue, 29 Apr 2008 00:48:11 -0700 | From | "SL Baur" <> | Subject | Re: patch sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.patch added to gregkh-2.6 tree |
| |
On 4/28/08, gregkh@suse.de <gregkh@suse.de> wrote: > > This is a note to let you know that I've just added the patch titled > > Subject: sysfs: add /sys/dev/{char,block} to lookup sysfs path by major:minor > > to my gregkh-2.6 tree. Its filename is > > sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.patch
> + char devt_str[15]; > + > + if (kobj) { > + format_dev_t(devt_str, dev->devt);
This part is ugly, but is not the fault of the patch. The ill- considered interface for `format_dev_t' is something that probably noone wants to fix.
Otherwise, still OK with me.
Reviewed-by: SL Baur <steve@xemacs.org>
(Is Reviewed-by not sticky?)
-sb
| |