lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: !x & y typo in mtrr code

* Al Viro <viro@ZenIV.linux.org.uk> wrote:

> On Sat, Apr 26, 2008 at 09:00:17PM -0700, Harvey Harrison wrote:
> > As written, this can never be true.
>
> ... and introduced through x86.git, of all things... May I suggest
> that in addition to all-important whitespace hunting something that
> catches lowly real bugs would also be run over that tree? sparse
> *does* catch that...

firstly, it _was_ caught via Sparse, secondly, if you check the code
flow, the bug - while indeed ugly looking - was harmless and had no
side-effects. That's why it didnt trigger in testing.

Ingo


\
 
 \ /
  Last update: 2008-04-29 23:07    [W:0.082 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site