Messages in this thread | | | Date | Tue, 29 Apr 2008 23:04:35 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: !x & y typo in mtrr code |
| |
* Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Sat, Apr 26, 2008 at 09:00:17PM -0700, Harvey Harrison wrote: > > As written, this can never be true. > > ... and introduced through x86.git, of all things... May I suggest > that in addition to all-important whitespace hunting something that > catches lowly real bugs would also be run over that tree? sparse > *does* catch that...
firstly, it _was_ caught via Sparse, secondly, if you check the code flow, the bug - while indeed ugly looking - was harmless and had no side-effects. That's why it didnt trigger in testing.
Ingo
| |