Messages in this thread | | | Date | Tue, 29 Apr 2008 11:49:54 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [2/2] vmallocinfo: Add caller information |
| |
On Mon, 28 Apr 2008, Arjan van de Ven wrote:
> > Sorry lost track of this issue. Adding stracktrace support is not a > > trivial thing and will change the basic handling of vmallocinfo. > > > > Not sure if stacktrace support can be enabled without a penalty on > > various platforms. Doesnt this require stackframes to be formatted in > > a certain way? > > it doesn't.
Hmmm... Why do we have CONFIG_FRAMEPOINTER then?
The current implementation of vmalloc_caller() follows what we have done with kmalloc_track_caller. Its low overhead and always on.
It would be great if we could have stacktrace support both for kmalloc and vmalloc in the same way also with low overhead but I think following a backtrace requires much more than simply storing the caller address. A mechanism like that would require an explicit kernel CONFIG option. A year or so ago we had patches to implement stacktraces in the slab allocators but they were not merged due to various arch specific issues with backtraces.
We could dump the offending x86_64 pieces. Some detail of what /proc/vmallocinfo would be lost then.
| |