lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] isicom: Fix buffer allocation
On Tue, Apr 29, 2008 at 02:17:33PM +0100, Alan Cox wrote:
> Fix the rather strange buffer management on open that turned up while
> auditing for BKL dependancies
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-mm1/drivers/char/isicom.c linux-2.6.25-mm1/drivers/char/isicom.c
> --- linux.vanilla-2.6.25-mm1/drivers/char/isicom.c 2008-04-28 11:36:48.000000000 +0100
> +++ linux-2.6.25-mm1/drivers/char/isicom.c 2008-04-14 10:56:25.000000000 +0100
> @@ -813,15 +813,13 @@
> return 0;
> if (!port->xmit_buf) {
> /* Relies on BKL */
> + unsigned long page = get_zeroed_page(GFP_KERNEL);
> + if (page == 0)
> return -ENOMEM;
> + if (port->xmit_buf)
> + free_page(page);
> + else
> + port->xmit_buf = (unsigned char *) page;
> }


Still looks rather strange. An if(x) inside an if(!x) ?

OG.


\
 
 \ /
  Last update: 2008-04-29 17:35    [W:0.038 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site