lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: vm86 - hide X86_VM_MASK from userland programs v2
    [Ingo Molnar - Mon, Apr 28, 2008 at 09:20:39PM +0200]
    |
    | Cyrill,
    |
    | randconfig testing in x86.git found a build bug and i bisected it to
    | your patch - output is below. Config attached. Looks like some config
    | file dependency hell problem? The dependencies there definitely need a
    | good look and a handful of cleanups as well.
    |
    | Ingo
    |
    | --------------------->
    | In file included from include/asm/vm86.h:139,
    | from include/asm/processor.h:11,
    | from include/asm/atomic_32.h:6,
    | from include/asm/atomic.h:3,
    | from include/linux/crypto.h:21,
    | from arch/x86/kernel/asm-offsets_32.c:8,
    | from arch/x86/kernel/asm-offsets.c:3:
    | include/asm/ptrace.h: In function 'user_mode_vm':
    | include/asm/ptrace.h:207: error: 'X86_VM_MASK' undeclared (first use in this function)
    | include/asm/ptrace.h:207: error: (Each undeclared identifier is reported only once
    | include/asm/ptrace.h:207: error: for each function it appears in.)
    | include/asm/ptrace.h: In function 'v8086_mode':
    | include/asm/ptrace.h:217: error: 'X86_VM_MASK' undeclared (first use in this function)

    Argh! Ingo, it seems that the real problem was introdused by

    commit 8fc37f2c474b8ea61186fd77193324845432447b
    Author: Thomas Gleixner <tglx@linutronix.de>
    Date: Tue Oct 23 22:37:24 2007 +0200

    x86: merge ptrace_32/64.h

    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

    with this patch we have <asm/vm86.h> included only
    if __i386__ defined *BUT* X86_VM_MASK is tried to be
    used *without* __386__ being checked (as example - ptrace.h:user_mode_vm).
    I'm not sure how to properly hanle this situation. But will take a look.

    So I suggest you drop my last patch (which moves X86_VM_MASK
    into __KERNEL__ section) for a while. I'll recheck all
    this stuff later (too busy now).

    - Cyrill -


    \
     
     \ /
      Last update: 2008-04-29 17:33    [W:2.213 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site