lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: patch sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.pat ch added to gregkh-2.6 tree
On Tue, Apr 29, 2008 at 12:48:11AM -0700, SL Baur wrote:
> On 4/28/08, gregkh@suse.de <gregkh@suse.de> wrote:
> >
> > This is a note to let you know that I've just added the patch titled
> >
> > Subject: sysfs: add /sys/dev/{char,block} to lookup sysfs path by major:minor
> >
> > to my gregkh-2.6 tree. Its filename is
> >
> > sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.patch
>
> > + char devt_str[15];
> > +
> > + if (kobj) {
> > + format_dev_t(devt_str, dev->devt);
>
> This part is ugly, but is not the fault of the patch. The ill-
> considered interface for `format_dev_t' is something that probably
> noone wants to fix.

Why not? Patches are always welcome, it's not like that function is
used in that many different places, should be a simple change...

> Otherwise, still OK with me.
>
> Reviewed-by: SL Baur <steve@xemacs.org>
>
> (Is Reviewed-by not sticky?)

Yes, it is, I'll add it to my version of the patch.

thanks,

greg k-h


\
 
 \ /
  Last update: 2008-04-29 17:29    [W:0.032 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site