Messages in this thread Patch in this message | | | Date | Tue, 29 Apr 2008 22:09:47 +0900 | From | Yasunori Goto <> | Subject | Re: [2.6 patch] mm/memory_hotplug.c must #include "internal.h" |
| |
-- > On Mon, 28 Apr 2008 20:40:08 +0300 Adrian Bunk <bunk@kernel.org> wrote: > > > This patch fixes the following compile error caused by > > commit 04753278769f3b6c3b79a080edb52f21d83bf6e2 > > (memory hotplug: register section/node id to free): > > > > <-- snip --> > > > > ... > > CC mm/memory_hotplug.o > > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/memory_hotplug.c: In function ___put_page_bootmem___: > > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/memory_hotplug.c:82: error: implicit declaration of function _____free_pages_bootmem___ > > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/memory_hotplug.c: At top level: > > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/memory_hotplug.c:87: warning: no previous prototype for ___register_page_bootmem_info_section___ > > make[2]: *** [mm/memory_hotplug.o] Error 1 > > > > <-- snip --> > > > > Signed-off-by: Adrian Bunk <bunk@kernel.org> > > > > --- > > 17f56d2d66ee41f504fcf0394687953c41afb8a4 diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index c4ba85c..b17dca7 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -29,6 +29,8 @@ > > > > #include <asm/tlbflush.h> > > > > +#include "internal.h" > > + > > /* add this memory to iomem resource */ > > static struct resource *register_memory_resource(u64 start, u64 size) > > { > > Argh. The -mm-only > memory-hotplug-add-removable-to-sysfs-to-show-memblock-removability.patch > debugging patch adds that include so nobody hit this before. > > I think I'll do an exploratory drop of that patch.
Hmm. I remember I included it when I posted the patch.
http://marc.info/?l=linux-kernel&m=120757279231150&w=2
But it seems to have been lost somewhere...
Thanks.
Yasunori Goto
| |