lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86_32: trim memory by updating e820 v3
On Tue, 29 Apr 2008 12:37:41 +0200 Ingo Molnar <mingo@elte.hu> wrote:

> +static int pci_create_attr(struct pci_dev *pdev, int num, int write_combine)
> +{
> + /* allocate attribute structure, piggyback attribute name */
> + int name_len = write_combine ? 13 : 10;
> + struct bin_attribute *res_attr;
> + int retval;
> +
> + res_attr = kzalloc(sizeof(*res_attr) + name_len, GFP_ATOMIC);

That (retained from current code) GFP_ATOMIC cannot be necessary.

> + if (res_attr) {
> + char *res_attr_name = (char *)(res_attr + 1);
> +
> + if (write_combine) {
> + pdev->res_attr_wc[num] = res_attr;
> + sprintf(res_attr_name, "resource%d_wc", num);
> + res_attr->mmap = pci_mmap_resource_wc;
> + } else {
> + pdev->res_attr[num] = res_attr;
> + sprintf(res_attr_name, "resource%d", num);
> + res_attr->mmap = pci_mmap_resource_uc;
> + }
> + res_attr->attr.name = res_attr_name;
> + res_attr->attr.mode = S_IRUSR | S_IWUSR;
> + res_attr->size = pci_resource_len(pdev, num);
> + res_attr->private = &pdev->resource[num];
> + retval = sysfs_create_bin_file(&pdev->dev.kobj, res_attr);

Because of this.

> + } else
> + retval = -ENOMEM;
> +
> + return retval;
> +}


\
 
 \ /
  Last update: 2008-04-29 14:45    [W:0.411 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site