Messages in this thread | | | Date | Tue, 29 Apr 2008 11:39:46 +0200 | From | Pierre Ossman <> | Subject | Re: Fwd: [PATCH] [MMC] fix clock problem in PXA255/270 |
| |
On Tue, 29 Apr 2008 08:49:17 +0200 Tadeusz Gozdek <linux_fan@o2.pl> wrote:
> Hi > As you can check, after finishing all operations clock is leaved as switched on (its switched off and on again during sending next command e.g. GO_INACTIVE_STATE). The same is after wake-up the system, even if the clock was switched off. > Switched on clock has sometimes an influence on the rest of the hardware e.g. the GPS modules and on battery life in a battery powered systems. >
That is a policy with possible side-effects (i.e. needs to be configurable), and host independent so it should be in the core. So I'm afraid I have to NAK your patch.
As a side-note, the PXA driver shouldn't be fiddling with the clock the way it does right now in the first place, but I have no maintainer to yell at. Patches removing that behaviour are very welcome.
Rgds -- -- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org
| |