Messages in this thread | | | Subject | RE: [PATCH] x86: !x & y typo in mtrr code | Date | Mon, 28 Apr 2008 16:16:44 -0700 | From | "Pallipadi, Venkatesh" <> |
| |
>-----Original Message----- >From: linux-kernel-owner@vger.kernel.org >[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of >Harvey Harrison >Sent: Saturday, April 26, 2008 9:00 PM >To: Ingo Molnar >Cc: Thomas Gleixner; H. Peter Anvin; LKML >Subject: [PATCH] x86: !x & y typo in mtrr code > >As written, this can never be true. >
My bad. I introduced this ugly and nasty bug.
Harvey: Thanks for catching the bug and the patch.
Thanks, Venki
>Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> >--- > arch/x86/kernel/cpu/mtrr/generic.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/arch/x86/kernel/cpu/mtrr/generic.c >b/arch/x86/kernel/cpu/mtrr/generic.c >index 353efe4..5d241ce 100644 >--- a/arch/x86/kernel/cpu/mtrr/generic.c >+++ b/arch/x86/kernel/cpu/mtrr/generic.c >@@ -90,7 +90,7 @@ u8 mtrr_type_lookup(u64 start, u64 end) > * Look of multiple ranges matching this address and pick type > * as per MTRR precedence > */ >- if (!mtrr_state.enabled & 2) { >+ if (!(mtrr_state.enabled & 2)) { > return mtrr_state.def_type; > } > >-- >1.5.5.1.270.g89765 > > > >-- >To unsubscribe from this list: send the line "unsubscribe >linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/ >
| |