lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 0/2] Immediate Values - jump patching update
Ingo Molnar wrote:
> * H. Peter Anvin <hpa@zytor.com> wrote:
>
>> Mathieu Desnoyers wrote:
>>> Thanks to Peter for the review.
>> Just in case someone gets the wrong idea...
>>
>> I still think this is the completely wrong approach.
>
> hm, can it result in a broken kernel? If yes, how? Or are your
> objections more higher level?
>

My objections are higher level, I believe the current code is (a)
painfully complex, and I'd rather not see it in the kernel, and (b) the
wrong thing anyway.

Put a 5-byte nop in as the marker, and patch it with a call instruction,
out of line, to a collector function.

-hpa


\
 
 \ /
  Last update: 2008-04-28 23:07    [W:0.119 / U:1.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site