lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] build: fix missing x86-specific help output
On Mon, Apr 28, 2008 at 11:18:39AM -0400, Andres Salomon wrote:
> Note that this one is a general x86 fix, I probably should've separated it
> out from the other three.
>
> On Fri, 25 Apr 2008 22:34:58 -0400
> Andres Salomon <dilinger@queued.net> wrote:
>
> >
> > Normally 'make help' spits out architecture-specific targets (including
> > things like foo_defconfig). However, it looks like ARCH was never changed
> > to SRCARCH during the x86 transition; the makefile still looks in
> > arch/i386/configs for arch-specific config files (if ARCH is i386, that is).
> >
> > This changes it to use SRCARCH, which makes it properly display things
> > like i386_defconfig and x86_64_defconfig.
> >
> > Signed-off-by: Andres Salomon <dilinger@debian.org>
> > ---
> > Makefile | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 3dbc826..e77149e 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1170,7 +1170,7 @@ rpm: include/config/kernel.release FORCE
> > # Brief documentation of the typical targets used
> > # ---------------------------------------------------------------------------
> >
> > -boards := $(wildcard $(srctree)/arch/$(ARCH)/configs/*_defconfig)
> > +boards := $(wildcard $(srctree)/arch/$(SRCARCH)/configs/*_defconfig)
> > boards := $(notdir $(boards))

I already had this fix in a previous patch.

> >
> > help:
> > @@ -1217,9 +1217,9 @@ help:
> > @echo 'Documentation targets:'
> > @$(MAKE) -f $(srctree)/Documentation/DocBook/Makefile dochelp
> > @echo ''
> > - @echo 'Architecture specific targets ($(ARCH)):'
> > + @echo 'Architecture specific targets ($(SRCARCH)):'
> > @$(if $(archhelp),$(archhelp),\
> > - echo ' No architecture specific help defined for $(ARCH)')
> > + echo ' No architecture specific help defined for $(SRCARCH)')

So I used only this part.

Sam


\
 
 \ /
  Last update: 2008-04-28 22:49    [W:0.042 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site