lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] pcspkr: fix dependancies
On Mon, Apr 28, 2008 at 10:12:25PM +0200, Sam Ravnborg wrote:
> On Mon, Apr 28, 2008 at 03:58:56PM -0400, Dmitry Torokhov wrote:
> > On Mon, Apr 28, 2008 at 11:34:14PM +0400, Stas Sergeev wrote:
> > > Hello.
> > >
> > > Dmitry Torokhov wrote:
> > > > It looks like the change was introduced by commit
> > > > 67926892ef7a7fbc76de607120d44416019fdf07
> > > Indeed. But the log message
> > > http://www.mail-archive.com/git-commits-head@vger.kernel.org/msg36026.html
> > > doesn't seem to specify the reason
> > > for the change, so this doesn't
> > > clarify a thing, unfortunately.
> > >
> > > > I think that we should register devices even if there is no driver in
> > > > the kernel for it because driver may be compiled at later time or be out
> > > > of tree. Adding patch author and other people that signed off the patch
> > > > to CC...
> > > Since there seem to be no objections,
> > > would you mind adding the patch to your
> > > git tree? Or who should that be?
> >
> > I try to stay within drivers/input boundaries ;) Ingo I think is the
> > person you need.
> If you google you will find a long thread about this patch.
> It is all about saving memory for embedded platforms.
> No need to have the driver if there is no speaker on the board.
>

The patch does it backwards though - it disables platform device if
there is no driver. We don't stop enumerating PCI devices if some of
them don't have a driver for them, do we? The arch code should not
create the device if it knows that the boards does not have it.

--
Dmitry


\
 
 \ /
  Last update: 2008-04-28 22:21    [W:0.074 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site