lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.25: pmac_newworld undefined
On Mon, Apr 28, 2008 at 02:20:44PM +1000, Tony Breeds wrote:
> On Sun, Apr 27, 2008 at 08:03:46PM +0200, Christian Kujau wrote:
> > Hi,
> >
> > the build failure reported[0] by Kamalesh back in 01/2008 is still
> > present in today's 2.6.25-git with CONFIG_NVRAM=m (instead of =y):
> >
> > Building modules, stage 2.
> > MODPOST 72 modules
> > ERROR: "pmac_newworld" [arch/powerpc/platforms/powermac/nvram.ko] undefined!
> > ERROR: "__alloc_bootmem" [arch/powerpc/platforms/powermac/nvram.ko]
> > undefined!
> > make[1]: *** [__modpost] Error 1
>
> Yeah that isn't really surprising. Essentially
> arch/powerpc/platforms/powermac/nvram.c must be builtin (not modular)
> but CONFIG_NVRAM is tristate, and your .config has CONFIG_NVRAM=m.
>
> We can probably "fix" this by adding another config config symbol and
> "selecting" that from CONFIG_NVRAM. Then using this new symbol in
> arch/powerpc/platforms/powermac/*
>
> so I think with we need is:
> config NVRAM
> bool "..." if PPC32
> tristate "..." if !PPC32
> ...
> ...
>
> Sam is there some way to achieve that or should we just create an
> secondary symbol?

In the Makefile you could just do a:

obj-$(CONFIG_NVRAM:m=y) += nvram.o

Then you would force nvram to be build-in.
That looks simpler than messing with Kconfig in this case.

Sam


\
 
 \ /
  Last update: 2008-04-28 21:37    [W:0.439 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site