lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] dvb: build failure fix
On Mon, Apr 28, 2008 at 06:24:21PM +0200, Ingo Molnar wrote:
>
> fix build failure found via x86.git randconfig testing:
>
> drivers/built-in.o: In function `tda829x_attach':
> : undefined reference to `tda827x_attach'
> drivers/built-in.o: In function `tda829x_attach':
> : undefined reference to `tda18271_attach'
>
> build failure is due to this nasty dependency:
>
> CONFIG_DVB_CORE=m but CONFIG_TUNER_TDA8290=y.
>
> the solution is to follow the DVB_CORE constraint in the Kconfig. It's
> not pretty but works.


It might work around the problem in your specific configuration, but
it's not the correct solution.

Please send your .config .


> Kconfig should be enhanced instead with a new keyword: "depends on
> instructure ..." that makes it clear that the dependent module can only
> be of equal or lesser link mode - but not =y while the infrastructure
> module is =m. But i digress.


What are you smoking?

That's exactly what "depends on" always did and still does.


> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> drivers/media/Kconfig | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> Index: linux/drivers/media/Kconfig
> ===================================================================
> --- linux.orig/drivers/media/Kconfig
> +++ linux/drivers/media/Kconfig
> @@ -106,21 +106,21 @@ if VIDEO_TUNER_CUSTOMIZE
>
> config TUNER_XC2028
> tristate "XCeive xc2028/xc3028 tuners"
> - depends on I2C && FW_LOADER
> + depends on I2C && FW_LOADER && ((DVB_CORE = m && m) || (DVB_CORE = y))
>...


Your funny additions are equivalent to "&& DVB_CORE".


cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-04-28 20:09    [W:0.064 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site