Messages in this thread | | | Date | Mon, 28 Apr 2008 10:09:17 -0700 | From | Mike Travis <> | Subject | Re: [PATCH] Fix calculus of bitmap_scnprintf_len() |
| |
Paul Jackson wrote: > Bert wrote: >> The function bitmap_scnprintf_len() is currently not used > > Paul Jackson wrote: >> How about we just remove that function? > > WANG Cong wrote: >> I am afraid no. See: >> >> include/linux/cpumask.h:292: return bitmap_scnprintf_len(len); > > Good point. > > > Then how about we also remove from cpumask.h: > > #define cpumask_scnprintf_len(len) \ > __cpumask_scnprintf_len((len)) > static inline int __cpumask_scnprintf_len(int len) > { > return bitmap_scnprintf_len(len); > } >
That's fine with me. A later version of the patch did have the function removed but it didn't get picked up. The other changes there were to use function pointers instead of the flag variable to select list or mask output format, and the addition of mask variants for the cpu/{present,possible, online,system} map outputs.
I'll dig that one back up and resubmit it.
Thanks, Mike
| |