lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kvm: how big is type?
Izik Eidus wrote:
> Avi Kivity wrote:
>
>> Harvey Harrison wrote:
>>
>>> arch/x86/kvm/x86.c:3484:25: warning: cast truncates bits from constant
>>> value (100 becomes 0)
>>> arch/x86/kvm/x86.c:3510:24: warning: cast truncates bits from constant
>>> value (100 becomes 0)
>>>
>>> The problem:
>>> cseg_desc.type &= ~(1 << 8); //clear the B flag
>>> nseg_desc.type |= (1 << 8);
>>>
>>> type is a 4-bit bitfield on x86....please look into this.
>>>
>>>
>>>
>> I think it ought to be (1 << 1), not (1 << 8), as it refers to the
>> "busy" bit of the task type. Izik?
>>
>>
>>
> From cf6e76c69a38a983df0c84a3dcc2336042eb3436 Mon Sep 17 00:00:00 2001
> From: Izik Eidus <izike@qumranet.com>
> Date: Mon, 28 Apr 2008 18:16:08 +0300
> Subject: [PATCH] KVM: x86: task switch: fix wrong bit setting for the busy flag.
> the busy bit is in offset of 1 inside type and not in 8.
>

Applied, thanks.


--
error compiling committee.c: too many arguments to function



\
 
 \ /
  Last update: 2008-04-28 18:13    [W:0.043 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site