lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: vget_cycles() __always_inline

* Hugh Dickins <hugh@veritas.com> wrote:

> Mark vget_cycles() as __always_inline, so gcc is never tempted to make
> the vsyscall vread_tsc() dive into kernel text, with resulting
> SIGSEGV.
>
> This was a self-inflicted wound: I've not seen that happen with
> unhacked sources; but for debug reasons I'd changed my x86/Makefile to
> compile no-unit-at-a-time, and that in conjunction with
> OPTIMIZE_INLINING=y ended up with vget_cycles() in kernel text.
> Perhaps it can happen in other ways: safer to use __always_inline.

applied, thanks Hugh - i agree that this is worth fixing.

Ingo


\
 
 \ /
  Last update: 2008-04-28 17:27    [W:0.044 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site