lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] ftrace: add trace pipe header pluggin

On Sat, 26 Apr 2008, Pekka Paalanen wrote:

> On Mon, 21 Apr 2008 17:09:37 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > This patch adds a method for open_pipe and open_read to the pluggins
> > so that they can add a header to the trace pipe call.
> >
> > Signed-off-by: Steven Rostedt <srostedt@redhat.com>
>
> In addition to this, I think I need tracer::close method called on
> tracing_release_pipe(). Use case: the reader closes the pipe before
> I have printed all of my header, i.e. walked through all PCI devices,
> so I need to properly destroy trace_iterator::private.

Good idea, I'll add that.

>
> I also intend to use trace_iterator::seq for printing my header, so I
> am looking if I can reuse code from tracing_read_pipe(). Looks like I'll
> extract the "return any leftover data" part into a separate function.
>
> To check trace_iterator::overrun, I'd like to be able to use
> for_each_tracing_cpu(), but that is local to trace.c.

I'll look into that.

>
> What happens when the tracing cpu mask changes? Mmiotrace does not take
> that into account and will continue to record with all CPUs, will this
> lead to problems, when mmiotrace starts to support SMP properly?

Good question. The tracing_cpu_mask isn't mine. So I'll need to know that
answer too.

>
> Now that I think of it, I probably want to use for_each_online_cpu()
> in checking for overruns... but that's not good either, if someone
> enables/disables a cpu during tracing. I guess you will have to / had to
> deal with this case in tracing core, too.

Good point.


-- Steve



\
 
 \ /
  Last update: 2008-04-28 15:07    [W:0.069 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site