lkml.org 
[lkml]   [2008]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ps3disk: Remove superfluous cast
On Wed, Apr 23 2008, Geert Uytterhoeven wrote:
> As ps3disk is a ppc64-only driver, sector_t equals to unsigned long, and the
> cast is not needed.
>
> Reuse in another (possibly 32-bit) driver is protected by the safety net called
> `compiler warning' (with the cast, it may silently truncate to 32-bit).
> If sector_t ever changes, we will get a compiler warning as well (with the
> cast, we won't).
>
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> Acked-by: Christoph Hellwig <hch@lst.de>
> ---
> Please apply, thx!

Applied

--
Jens Axboe



\
 
 \ /
  Last update: 2008-04-27 12:37    [W:0.031 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site