Messages in this thread | | | Date | Sun, 27 Apr 2008 18:51:35 -0700 | From | "Chris Peterson" <> | Subject | Re: [PATCH] fix warning: remove unused static function in drivers/char/ip2/i2ellis.c |
| |
Yes, I did compile it, but I now realize I had compiled the computone driver to be linked statically, but iiEllisCleanup() is only called when the driver is built as a module. What is the appropriate cleanup code path for non-modular drivers?
chris
On Sun, Apr 27, 2008 at 12:42 AM, Jiri Slaby <jirislaby@gmail.com> wrote: > On 04/27/2008 09:09 AM, Chris Peterson wrote: > > > This patch against linux-2.6.25-git7. > > > > chris > > > > > > Signed-off-by: Chris Peterson <cpeterso@cpeterso.com> > > --- > > diff -Naur linux-2.6.25-git7/drivers/char/ip2/i2ellis.c > > linux-2.6.25-git7+patch/drivers/char/ip2/i2ellis.c > > --- linux-2.6.25-git7/drivers/char/ip2/i2ellis.c 2008-04-25 > > 22:47:01.000000000 -0700 > > +++ linux-2.6.25-git7+patch/drivers/char/ip2/i2ellis.c 2008-04-25 > > 23:19:57.000000000 -0700 > > @@ -86,22 +86,6 @@ > > } > > > > > //****************************************************************************** > > -// Function: iiEllisCleanup() > > -// Parameters: None > > -// > > -// Returns: Nothing > > -// > > -// Description: > > -// > > -// This routine performs any required cleanup of the iiEllis subsystem. > > -// > > > -//****************************************************************************** > > -static void > > -iiEllisCleanup(void) > > -{ > > -} > > > > Well, have you tried to even build it? The .c file is *included* into > i2main.c where this function is used. > > NAK >
| |