Messages in this thread | | | Date | Mon, 28 Apr 2008 01:45:07 +0100 | From | Al Viro <> | Subject | Re: [patch] x86, voyager: fix ioremap_nocache() |
| |
On Sun, Apr 27, 2008 at 08:31:27PM -0400, Rik van Riel wrote: > On Sun, 27 Apr 2008 16:31:06 -0700 (PDT) > David Miller <davem@davemloft.net> wrote: > > > You can post whatever patches you like a million times to lkml. > > That's not the problem. > > > > It's that the patches don't get reviewed, posting them more or to a > > different place doesn't help that. > > If you really want to enforce this, I bet it could be automated > with scripts around git. > > Simply refuse to apply a patch that does not have at least two > Signed-off-by/Reviewed-by/Acked-by lines and refuse to apply > a "git pull" if there is a changeset like that in the tree.
Yeah, right. commit 138fe4e069798d9aa948a5402ff15e58f483ee4e Author: Konrad Rzeszutek <ketuzsezr@darnok.org> Date: Wed Apr 9 19:50:41 2008 -0700
Firmware: add iSCSI iBFT Support ... [akpm@linux-foundation.org: fix build] Signed-off-by: Konrad Rzeszutek <konradr@linux.vnet.ibm.com> Cc: Mike Christie <michaelc@cs.wisc.edu> Cc: Peter Jones <pjones@redhat.com> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> ... +static ssize_t sprintf_ipaddr(char *buf, u8 *ip) +{ ... + str += sprintf(str, NIP6_FMT, ntohs(ip[0]), ntohs(ip[1]), + ntohs(ip[2]), ntohs(ip[3]), ntohs(ip[4]), + ntohs(ip[5]), ntohs(ip[6]), ntohs(ip[7]));
are you going to tell me that this had been reviewed? Note these ntohs() applied to 8bit values in there. Two signed-off-by, including Greg "two s-o-b are enough to guarantee review"...
| |