Messages in this thread | | | Subject | Re: [PATCH] bitops: simplify generic bit finding functions | From | Harvey Harrison <> | Date | Sun, 27 Apr 2008 13:29:21 -0700 |
| |
On Sun, 2008-04-27 at 13:26 -0700, Linus Torvalds wrote: > > On Sun, 27 Apr 2008, Harvey Harrison wrote: > > > > No need for a sentinal if we explicitly catch the no bits/all bits set > > cases, make it clear they are special cases returning size/BITS_PER_LONG. > > These things need to be re-done anyway. David already complained that the > thing inlines to something much much too big. > > Let's just make it not be an inline at all.
Oh, I didn't realize, I only did this because sparse started spewing out lots of: include/linux/bitops.h:166:32: warning: shift too big (65536) for type unsigned long
due to shift by size there, and again on line 202...I just wanted something that sparse wouldn't warn about and was a little easier to understand to boot.
Cheers,
Harvey
| |