lkml.org 
[lkml]   [2008]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] blackfin checksum annotations
On Sat, Apr 26, 2008 at 10:26:44PM -0700, David Miller wrote:
> From: Al Viro <viro@ZenIV.linux.org.uk>
> Date: Sun, 27 Apr 2008 06:22:26 +0100
>
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> Since these are networking knobs and Al tends to test his
> changes, I'll apply this to the net-2.6 tree.

FSVOtest in this case, since I don't have the hardware... However,
all changes seen by gcc are actually
* explicit cast to unsigned short in return expression of functions
returning unsigned short
* csum_fold() return type changed from unsigned int to __sum16
(unsigned short), same as for all other architecture and as net/* expects;
expression actually returned is ((~(sum << 16)) >> 16) with sum being
unsigned 32bit, so it's (a) going to fit into the range of unsigned short
and (b) had been unsigned all along, so no sign expansion mess happened.

IOW, it should not break runtime, but... untested is untested.


\
 
 \ /
  Last update: 2008-04-27 07:41    [W:0.046 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site