lkml.org 
[lkml]   [2008]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH][Resend] PCI Express ASPM support should default to 'No'
From
From: Jesper Juhl <jesper.juhl@gmail.com>

[This patch was previously submitted 23 April 2008 00:28]

Andrew; if you could merge this in -mm it would be good, otherwise I'll
just queue it up in the trivial tree for the next merge window.


Running 'make oldconfig' I just noticed that PCIEASPM defaults to
'y' in Kconfig even though the feature is experimental and the
help text recommends that if you are unsure you say 'n'.
It seems to me that this really should default to 'n', not 'y'.
The following patch makes that change. Please consider merging.

Jesse Barnes commented on the patch that it "Seem reasonable".
Shaohua Li also commented saying "Ok, I'm fine with the patch."

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
index 25b04fb..5a0c6ad 100644
--- a/drivers/pci/pcie/Kconfig
+++ b/drivers/pci/pcie/Kconfig
@@ -33,7 +33,7 @@ source "drivers/pci/pcie/aer/Kconfig"
config PCIEASPM
bool "PCI Express ASPM support(Experimental)"
depends on PCI && EXPERIMENTAL && PCIEPORTBUS
- default y
+ default n
help
This enables PCI Express ASPM (Active State Power Management) and
Clock Power Management. ASPM supports state L0/L0s/L1.



\
 
 \ /
  Last update: 2008-04-27 22:09    [W:0.040 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site