Messages in this thread Patch in this message | | | Date | Sat, 26 Apr 2008 11:57:57 +0200 | From | Ingo Molnar <> | Subject | Re: [git pull] x86 PAT changes |
| |
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> Also, it causes this message for me on one of my machines: > > EXT3-fs: mounted filesystem with ordered data mode. > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > mtrr: no more MTRRs available > Overlap at 0xd0000000-0xe0000000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0380000 > EXT3 FS on dm-0, internal journal > ... > eth0: no IPv6 routers present > Overlap at 0xd0000000-0xe0000000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0380000 > Overlap at 0xd0000000-0xe0000000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0380000 > Overlap at 0xd0000000-0xe0000000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0380000 > Overlap at 0xd0000000-0xe0000000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0380000 > Overlap at 0xd0000000-0xe0000000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0380000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xd0000000-0xd0020000 > mtrr: no more MTRRs available > Overlap at 0xd0000000-0xe0000000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0380000 > > which is a bit annoying. Forgotten debug printk, perhaps?
yeah - i already toned it down to KERN_INFO once in commit 28eb559b5 - but it should be pr_debug() instead. The idea in pat.c is to only print out if it's a material condition that the user should know about. I've queued up the patch below.
Ingo
--------> Subject: x86 PAT: tone down debugging messages From: Ingo Molnar <mingo@elte.hu> Date: Sat Apr 26 11:40:31 CEST 2008
Linus reported these excessive debug printouts:
> Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0380000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000 > Overlap at 0xe0300000-0xe0400000
turn that into a pr_debug().
Signed-off-by: Ingo Molnar <mingo@elte.hu> --- arch/x86/mm/pat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-x86.q/arch/x86/mm/pat.c =================================================================== --- linux-x86.q.orig/arch/x86/mm/pat.c +++ linux-x86.q/arch/x86/mm/pat.c @@ -334,7 +334,7 @@ int reserve_memtype(u64 start, u64 end, break; } - printk("Overlap at 0x%Lx-0x%Lx\n", + pr_debug("Overlap at 0x%Lx-0x%Lx\n", saved_ptr->start, saved_ptr->end); /* No conflict. Go ahead and add this new entry */ list_add(&new_entry->nd, saved_ptr->nd.prev);
| |