lkml.org 
[lkml]   [2008]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
On Sat, Apr 26, 2008 at 04:07:01PM -0400, Christoph Hellwig wrote:
> On Sat, Apr 26, 2008 at 10:02:17PM +0200, Andi Kleen wrote:
> > Denys Vlasenko <vda.linux@googlemail.com> writes:
> > >
> > > Compile tested only.
> >
> > You should mark the helper noinline just to prevent gcc from possibly
> > inlining it. Even if it doesn't with your current compiler inline heuristics
> > vary widely between compiler versions.
>
> STATIC as defined by xfs already does this..

Weird. Unexpected. Different from everyone else. Is this some exercise in
obfuscation?

But ok.

-Andi


\
 
 \ /
  Last update: 2008-04-26 22:23    [W:1.706 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site