lkml.org 
[lkml]   [2008]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [git pull] generic bitops, take 2


    On Sat, 26 Apr 2008, Ingo Molnar wrote:
    >
    > i've added Alexander's patch that does the cleanup suggested by you

    Well.. Not really:

    > diff --git a/arch/um/Kconfig.x86_64 b/arch/um/Kconfig.x86_64
    > index 3fbe69e..7a75043 100644
    > --- a/arch/um/Kconfig.x86_64
    > +++ b/arch/um/Kconfig.x86_64
    > @@ -27,6 +27,14 @@ config SMP_BROKEN
    > bool
    > default y
    >
    > +config GENERIC_FIND_FIRST_BIT
    > + bool
    > + default y
    > +
    > +config GENERIC_FIND_NEXT_BIT
    > + bool
    > + default y
    > +

    It still declares this GENERIC_FIND_*_BIT thing separately for UM.

    Yes, that may _work_, but it's wrong to define it in two different places.

    It also makes me wonder why Kconfig.i386 can just include
    arch/x86/Kconfig.cpu, but x86_64 cannot?

    Linus


    \
     
     \ /
      Last update: 2008-04-26 19:07    [W:4.251 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site