Messages in this thread | | | Date | Sat, 26 Apr 2008 18:34:14 +0200 | From | Jean Delvare <> | Subject | Re: [fix] [git pull] VFS patches |
| |
On Sat, 26 Apr 2008 05:25:00 +0100, Al Viro wrote: > Arrgghhh... > > Sorry about that, I'd been sure I'd folded that one, but it actually got > lost. Please apply - that breaks execve(). > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> > --- > > diff --git a/kernel/fork.c b/kernel/fork.c > index 4df3949..a647542 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -1788,7 +1788,7 @@ bad_unshare_out: > int unshare_files(struct files_struct **displaced) > { > struct task_struct *task = current; > - struct files_struct *copy; > + struct files_struct *copy = NULL; > int error; > > error = unshare_fd(CLONE_FILES, ©);
This apparently prevents the general protection faults I was hitting with 2.6.25-git8. Linus, please apply Al's fixup patch quickly, as it will probably hit pretty much everyone trying it.
Thanks, -- Jean Delvare
| |