Messages in this thread Patch in this message | | | Date | Fri, 25 Apr 2008 00:26:36 -0700 (PDT) | Subject | Re: [SPARC64] INO problem Re: [Bug 10273] New: Sun GEM (PCI) - network device doesn't work | From | David Miller <> |
| |
From: Jarek Poplawski <jarkao2@gmail.com> Date: Wed, 2 Apr 2008 20:26:55 +0200
> Nice work Jos! I forward it to the author and the lists.
I haven't forgotten about this bug report, in fact I did some investigation and thinking about it.
I think the case being triggered in the new code is IRQ_DISABLED.
If this is the problem, I suspect that what needs to happen is that when we re-enable the interrupt we have to forcefully hit the clear register to put it back into transmit state. Otherwise it can get stuck.
Please give this patch a try (this is against 2.6.23, which is the version you reported the bug against, let me know if another version is more convenient).
Thanks!
diff --git a/arch/sparc64/kernel/irq.c b/arch/sparc64/kernel/irq.c index 2395609..98b68d2 100644 --- a/arch/sparc64/kernel/irq.c +++ b/arch/sparc64/kernel/irq.c @@ -313,6 +313,8 @@ static void sun4u_irq_enable(unsigned int virt_irq) IMAP_AID_SAFARI | IMAP_NID_SAFARI); val |= tid | IMAP_VALID; upa_writeq(val, imap); + + upa_writeq(ICLR_IDLE, data->iclr); } }
| |