Messages in this thread |  | | Date | Fri, 25 Apr 2008 14:25:32 -0500 | From | Robin Holt <> | Subject | Re: [PATCH 1 of 9] Lock the entire mm to prevent any mmu related operation to happen |
| |
On Fri, Apr 25, 2008 at 06:56:40PM +0200, Andrea Arcangeli wrote: > Fortunately I figured out we don't really need mm_lock in unregister > because it's ok to unregister in the middle of the range_begin/end > critical section (that's definitely not ok for register that's why > register needs mm_lock). And it's perfectly ok to fail in register().
I think you still need mm_lock (unless I miss something). What happens when one callout is scanning mmu_notifier_invalidate_range_start() and you unlink. That list next pointer with LIST_POISON1 which is a really bad address for the processor to track.
Maybe I misunderstood your description.
Thanks, Robin
|  |