lkml.org 
[lkml]   [2008]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] x86: fix text_poke


On Fri, 25 Apr 2008, Ingo Molnar wrote:
>
> performance i dont think we should be too worried about at this moment -
> this code is so rarely used that it should be driven by robustness i
> think.

That really isn't true. This isn't done just once. It's done many
thousands of times.

I agree that it has to be robust, but if we want to make suspend/resume
be instantaneous (and we do), performance does actually matter. Yes, this
is probably much less of a problem than waiting for devices, and no, I
haven't timed it, but if I counted right, we'll literally be going almost
ten thousand of these calls over a suspend/resume cycle.

That's not "rarely used".

Linus


\
 
 \ /
  Last update: 2008-04-25 19:17    [W:0.138 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site