lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [git pull] generic bitops
From
Date
On Thu, 2008-04-24 at 15:14 -0700, Linus Torvalds wrote:
>
> On Thu, 24 Apr 2008, Ingo Molnar wrote:
> >
> > this started out as improvements/generalizations to x86 bitops, but grew
> > generic impact (and generic optimizations) as well, so it's offered as a
> > separate tree.
>
> Can you do the config thing differently?
>
> > diff --git a/arch/um/Kconfig.i386 b/arch/um/Kconfig.i386
> > index e09edfa..49990ea 100644
> > --- a/arch/um/Kconfig.i386
> > +++ b/arch/um/Kconfig.i386
> > @@ -39,6 +39,14 @@ config ARCH_REUSE_HOST_VSYSCALL_AREA
> > bool
> > default y
> >
> > +config GENERIC_FIND_FIRST_BIT
> > + bool
> > + default y
> > +
> > +config GENERIC_FIND_NEXT_BIT
> > + bool
> > + default y
> > +
>
> .. because instead of having each architecture do these kinds of things,
> we're trying to make the *generic* code (ie lib/Kconfig) do
>
> config GENERIC_FIND_FIRST_BIT
> bool
> default n

config HAVE_GENERIC_FIND_FIRST_BIT
def_bool n

(I know it defaults to n, but this pattern is becoming suggestive of
features that must be selected, in addition to the HAVE_ prefix)

Although I think for lib stuff, we may want to think about WANT_
prefixes to suggest you have to opt in.

Harvey



\
 
 \ /
  Last update: 2008-04-25 00:45    [W:0.074 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site