lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] RxRPC: Fix a regression in the RXKAD security module


On Thu, 24 Apr 2008, David Howells wrote:
>
> Fix a regression in the RXKAD security module introduced in:
>
> commit 91e916cffec7c0153c5cbaa447151862a7a9a047
> Author: Al Viro <viro@ftp.linux.org.uk>
> Date: Sat Mar 29 03:08:38 2008 +0000
>
> net/rxrpc trivial annotations
>
> A variable was declared as a 16-bit type rather than a 32-bit type.

Ok, that looks stupid, and should even have had a warning (shifting a u16
right by 16 should warn about it being pointless, but doesn't, because the
compiler quietly expands it to "int" in the meantime).

Hmm. I could do something to sparse that warns about that too.

Linus


\
 
 \ /
  Last update: 2008-04-24 22:49    [W:0.036 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site