Messages in this thread | | | Date | Thu, 24 Apr 2008 13:45:51 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] RxRPC: Fix a regression in the RXKAD security module |
| |
On Thu, 24 Apr 2008, David Howells wrote: > > Fix a regression in the RXKAD security module introduced in: > > commit 91e916cffec7c0153c5cbaa447151862a7a9a047 > Author: Al Viro <viro@ftp.linux.org.uk> > Date: Sat Mar 29 03:08:38 2008 +0000 > > net/rxrpc trivial annotations > > A variable was declared as a 16-bit type rather than a 32-bit type.
Ok, that looks stupid, and should even have had a warning (shifting a u16 right by 16 should warn about it being pointless, but doesn't, because the compiler quietly expands it to "int" in the meantime).
Hmm. I could do something to sparse that warns about that too.
Linus
| |